-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow forc deploy to submit transaction without waiting for commit confirmation #6294
Allow forc deploy to submit transaction without waiting for commit confirmation #6294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… lb/feat/deploy-submit-only
Hey @sdankel , is it necessary to include --submit-only in the forc deploy documentation? If so, which file should I add it to? |
# Conflicts: # forc-plugins/forc-client/src/op/deploy.rs # forc-plugins/forc-client/tests/deploy.rs
… lb/feat/deploy-submit-only
Hey @luisburigo - good call out, and yes we should include it in the docs here. It would be great if you could add a short section at the end about multisig with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit about the documentation - otherwise LGTM :)
… lb/feat/deploy-submit-only
…it-only # Conflicts: # forc-plugins/forc-client/src/op/deploy.rs # forc-plugins/forc-client/tests/deploy.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but CI is failing on spellchecking the word multisig
; multisig
needs to be added into the list in docs/book/spell-check-custom-words.txt
done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
The current
forc deploy
command is designed to submit and await for transaction finalization as much this is a common use case, for delayed transactions, were transaction are submitted but can take time a lot of time to be included and finalized. For this use cases I have implement a suggestion--submit-only
this will follow the current flow, but only submit the transaction.Example use case for delayed transactions
In Bako Safe, as it is a multisig, it is necessary to have signatures from multiple accounts before sending the transaction to the network. To work together with forc deploy, a GraphQL Proxy has been developed that works with the Fuel provider to allow sending the transaction to our protocol.
forc deploy --node-url 'https://api.bako.global/v1/graphql' --default-signer --submit-only
Changes
--submit-only
submit_only
command is providedChecklist
Breaking*
orNew Feature
labels where relevant.